Build: Don't auto-trigger CI on release PRs #23198
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JReinhold
added
patch:yes
JReinhold
commented
Jun 23, 2023
Comment on lines
-12
to
-13
| - version-prerelease-from-** | ||
| - version-patch-from-** |
There was a problem hiding this comment.
we don't need this as it should already be covered by "pull_request_target" > "synchronize", and removing these makes sure the "merged" workflow doesn't trigger unnecessarily.
JReinhold
commented
Jun 23, 2023
| @@ -56,7 +54,7 @@ jobs: | |||
| trigger-pr-tests: | |||
| runs-on: ubuntu-latest | |||
| needs: get-branch | |||
| if: github.event_name == 'pull_request_target' && ((github.event.pull_request.draft == false || contains(github.event.pull_request.labels.*.name, 'ci:pr')) && !contains(github.event.pull_request.labels.*.name, 'ci:merged') && !contains(github.event.pull_request.labels.*.name, 'ci:daily')) | |||
| if: github.event_name == 'pull_request_target' && (((github.event.pull_request.draft == false && !contains(github.event.pull_request.labels.*.name, 'release')) || contains(github.event.pull_request.labels.*.name, 'ci:pr')) && !contains(github.event.pull_request.labels.*.name, 'ci:merged') && !contains(github.event.pull_request.labels.*.name, 'ci:daily')) | |||
There was a problem hiding this comment.
trigger PR tests if:
- is "pull_request_target" event
- AND
- (not draft
- AND not "release")
- OR has "ci:pr" label
- AND don't have "ci:merged"
- AND don't have "ci:daily"
JReinhold
added a commit
that referenced
this pull request
Jun 23, 2023
Build: Don't auto-trigger CI on release PRs (cherry picked from commit 1d61076)
This was referenced Jun 23, 2023
Merged
JReinhold
added a commit
that referenced
this pull request
Jun 23, 2023
Build: Don't auto-trigger CI on release PRs (cherry picked from commit 1d61076)
JReinhold
added a commit
that referenced
this pull request
Jun 24, 2023
Build: Don't auto-trigger CI on release PRs (cherry picked from commit 1d61076)
JReinhold
added a commit
that referenced
this pull request
Jun 26, 2023
Build: Don't auto-trigger CI on release PRs (cherry picked from commit 1d61076)
JReinhold
added a commit
that referenced
this pull request
Jun 26, 2023
Build: Don't auto-trigger CI on release PRs (cherry picked from commit 1d61076)
JReinhold
added a commit
that referenced
this pull request
Jun 26, 2023
5 tasks
JReinhold
added a commit
that referenced
this pull request
Jun 27, 2023
Build: Don't auto-trigger CI on release PRs (cherry picked from commit 1d61076)
JReinhold
added a commit
that referenced
this pull request
Jun 27, 2023
Build: Don't auto-trigger CI on release PRs (cherry picked from commit 1d61076)
JReinhold
added a commit
that referenced
this pull request
Jun 27, 2023
Build: Don't auto-trigger CI on release PRs (cherry picked from commit 1d61076)
JReinhold
added a commit
that referenced
this pull request
Jun 27, 2023
Build: Don't auto-trigger CI on release PRs (cherry picked from commit 1d61076)
JReinhold
added
the
patch:done
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
We don't want to trigger CI on any updates to release PRs because they update frequently and it's a waste to run CI before we actually are ready for the release process.
Now the Releaser have to manually add the ci:daily label to trigger CI on changes.
How to test
Checklist
MIGRATION.MD
Maintainers
make sure to add the
ci:mergedorci:dailyGH label to it.["cleanup", "BREAKING CHANGE", "feature request", "bug", "documentation", "maintenance", "dependencies", "other"]